refactor: merge multiple EntryPointType structs #1318
Conversation
noaov1
force-pushed
the
noa/unify_ep_type_enum
branch
11 times, most recently
from
60411ad
to
939d400
Compare
noaov1
force-pushed
the
noa/unify_ep_type_enum
branch
from
939d400
to
faf52e8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1318 +/- ##
==========================================
- Coverage 74.18% 71.63% -2.56%
==========================================
Files 359 207 -152
Lines 36240 25824 -10416
Branches 36240 25824 -10416
==========================================
- Hits 26886 18499 -8387
+ Misses 7220 5694 -1526
+ Partials 2134 1631 -503
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
noaov1
requested review from
dorimedini-starkware,
yair-starkware and
meship-starkware
There was a problem hiding this comment.
Reviewed 32 of 34 files at r1, all commit messages.
Reviewable status: 32 of 34 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware, @noaov1, and @yair-starkware)
crates/papyrus_test_utils/src/lib.rs line 599 at r1 (raw file):
External = 1, L1Handler = 2, }
Does this test enum and the real one have the same meaning?
Code quote:
pub enum DeprecatedEntryPointType {
Constructor = 0,
External = 1,
L1Handler = 2,
}
There was a problem hiding this comment.
Reviewed 2 of 34 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware, @noaov1, and @yair-starkware)
There was a problem hiding this comment.
Reviewed 34 of 34 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @noaov1)
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1)
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @noaov1)
crates/papyrus_test_utils/src/lib.rs line 599 at r1 (raw file):
Previously, meship-starkware (Meshi Peled) wrote…
Does this test enum and the real one have the same meaning?
Yes
This change is